Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): add billing snapshot config validate service to usage reports #291

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Dec 7, 2023

PR summary

Adding new API to validate s2s authentication in billing snapshot configuration service in usage reports.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/services/billing/apptio-integration.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/2102

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…usage reports

Signed-off-by: manu.k.m <manu.k.m@ibm.com>
@manukm-ibm
Copy link
Member Author

Integration test results of new changes
Screenshot 2023-12-01 at 2 37 55 PM

Examples results of new changes
Screenshot 2023-12-01 at 2 40 48 PM

@padamstx padamstx self-requested a review December 7, 2023 22:15
@padamstx padamstx self-assigned this Dec 7, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title feat(Usage Reports): add billing snapshot congif validate service to usage reports feat(Usage Reports): add billing snapshot config validate service to usage reports Dec 7, 2023
@padamstx padamstx merged commit da51703 into IBM:main Dec 8, 2023
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Dec 8, 2023
# [0.55.0](v0.54.1...v0.55.0) (2023-12-08)

### Features

* **Usage Reports:** add billing snapshot config validate service to usage reports ([#291](#291)) ([da51703](da51703))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.55.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants