Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (ATracker): add support for Cloud Logs target type #314

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

veenanr
Copy link
Contributor

@veenanr veenanr commented Apr 1, 2024

PR summary

Add support for a new ATracker target type (cloud-logs) and its endpoint fields

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

ATracker will support a new target type (cloud-logs) in addition to the existing target types

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Unit tests results:

veenarao$ go test
go: downloading github.com/onsi/gomega v1.31.1
Running Suite: AtrackerV2 Suite
===============================
Random Seed: 1712004023
Will run 94 of 94 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 94 of 94 Specs in 4.006 seconds
SUCCESS! -- 94 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv2	5.064s

Integration test results:

veenarao$ go test github.com/IBM/platform-services-go-sdk/atrackerv2 -tags="integration" -v
=== RUN   TestAtrackerV2
Running Suite: AtrackerV2 Suite
===============================
Random Seed: 1712004111
Will run 137 of 137 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
------------------------------
• [SLOW TEST:7.479 seconds]
AtrackerV2 Integration Tests
/Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk/atrackerv2/atracker_v2_integration_test.go:42
  DeleteTarget - Delete a target
  /Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk/atrackerv2/atracker_v2_integration_test.go:756
    DeleteTarget(deleteTargetOptions *DeleteTargetOptions)
    /Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk/atrackerv2/atracker_v2_integration_test.go:804
------------------------------

Ran 137 of 137 Specs in 16.669 seconds
SUCCESS! -- 137 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAtrackerV2 (16.71s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv2	17.733s

@veenanr veenanr requested a review from padamstx April 1, 2024 20:52
@padamstx padamstx changed the title fix (ATracker: regen-atracker-04012024 Add Cloud Logs target type sup… fix (ATracker): add support for Cloud Logs target type Apr 1, 2024
@padamstx padamstx self-assigned this Apr 1, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, except the copyright year in a couple files. Could you fix that please?

atrackerv2/atracker_v2_integration_test.go Outdated Show resolved Hide resolved
atrackerv2/atracker_v2_examples_test.go Outdated Show resolved Hide resolved
…port

Signed-off-by: Veena Rao <veenar@us.ibm.com>
Signed-off-by: Veena Rao <veenar@us.ibm.com>
Signed-off-by: Veena Rao <veenar@us.ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 9bfbb78 into main Apr 2, 2024
4 checks passed
@padamstx padamstx deleted the regen-atracker-04012024 branch April 2, 2024 13:53
ibm-devx-sdk pushed a commit that referenced this pull request Apr 2, 2024
## [0.62.1](v0.62.0...v0.62.1) (2024-04-02)

### Bug Fixes

* **ATracker:** add support for Cloud Logs target type ([#314](#314)) ([9bfbb78](9bfbb78))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.62.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants