Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z/Open Editor hasn’t seemingly taken account of the Keytar removal from VSCode #359

Closed
davidkjackson54 opened this issue Oct 9, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@davidkjackson54
Copy link

It appears that z/Open Editor has not catered for the documented removal of keytar from VSCode that was released over the past few days.

IMG_1167

@ibmrcruicks
Copy link

This "error" - flagged with a warning triangle - does not appear to indicate any actual problem with the editors. As long as ZOWE version and VSCode versions are compatible, the editor opens just fine on MVS and USS datasets and files.
What does produce an error is trying to find and set the "Zowe Security:Credential Key" as this is no longer provided by the ZOWE extension

@davidkjackson54
Copy link
Author

This problem started to occur yesterday after the update of VSCode v1.83.0 . Nothing else changed. The problem occurs immediately on VSCode startup.

@ibmrcruicks
Copy link

V1.83 removed the keytar shim - the Db2 Developer Extension is now properly broken; z Open Editor's error suggests it is broken but probably isn't.
The error definitely needs fixed/removed to avoid confusion.

@davidkjackson54 davidkjackson54 changed the title Z/Open Editor hasn’t taken account of the Keytar removal from VSCode Z/Open Editor hasn’t seemingly taken account of the Keytar removal from VSCode Oct 9, 2023
@phaumer phaumer self-assigned this Oct 9, 2023
@phaumer
Copy link
Member

phaumer commented Oct 9, 2023

We have replaced keytar with a new library in Zowe Explorer already for a while now. This error in Z Open Editor pops up because of a test we had forgotten to remove in time. For now you can ignore the warning as the functionality is not impacted. Our next release will have the warning removed. Our apologies for the inconvenience.

@phaumer phaumer added the bug Something isn't working label Oct 9, 2023
@ibmrcruicks
Copy link

@phaumer - when is that release due? We have many "new to Z" users who are currently encountering this error as their first experience with open source access to IBM Z.

@phaumer
Copy link
Member

phaumer commented Oct 9, 2023

@ibmrcruicks I understand, but we cannot talk about release dates outside of the official IBM announcements.

@phaumer
Copy link
Member

phaumer commented Oct 12, 2023

@ibmrcruicks @davidkjackson54 we just published an emergency fix with version 3.2.3 that gets rid of the dialog.

@phaumer phaumer closed this as completed Oct 12, 2023
@ibmrcruicks
Copy link

thanks for the speedy turnaround!

@davidkjackson54
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants