Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plt_kde_1d,2d: pass boundaries as limits dict #252

Open
yannikschaelte opened this issue Jan 22, 2020 · 5 comments
Open

plt_kde_1d,2d: pass boundaries as limits dict #252

yannikschaelte opened this issue Jan 22, 2020 · 5 comments

Comments

@yannikschaelte
Copy link
Member

This will make the 1d,2d interface easier to use and more similar to the matrix plotting function.

@sebgoti
Copy link

sebgoti commented Mar 23, 2021

Hi Yannik, I am Sebastian from TU Dresden and wanted to start contributing to the pyABC project. May I take this as a first issue to solve?

@yannikschaelte
Copy link
Member Author

That would be appreciated! Regarding this issue, I suggest adding to plot_kde_{1/2}d_{highlevel/} an additional argument limits, which is then evaluated in plot_kde_{1/2}d. For legacy reasons, I would keep the old xmin, xmax, ymin, ymax, and to throw an error of both limits is not None and any(val is not None for val in [xmin, xmax, ymin, ymax])? And if limit is defined, then extract xmin etc. from limits internally?

@yannikschaelte
Copy link
Member Author

Same would also make sense for the histogram routines https://github.com/ICB-DCM/pyABC/blob/main/pyabc/visualization/histogram.py

@sebgoti
Copy link

sebgoti commented Mar 23, 2021

Great! I will start working on it and will let you know about anything that may come up.

@yannikschaelte
Copy link
Member Author

Let me know if there are any questions! See also our contributor's guide, maybe useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants