Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitmask/flags rasters should only be read when flags param is set #312

Closed
elidwa opened this issue Sep 7, 2023 · 1 comment
Closed

Bitmask/flags rasters should only be read when flags param is set #312

elidwa opened this issue Sep 7, 2023 · 1 comment
Assignees
@elidwa

Comments

@elidwa
Copy link
Contributor

elidwa commented Sep 7, 2023

Currently raster sample() call reads both raster and it associated quality mask raster. If the flags param is set the flags value is populated.
Subset() call has flags rasters disabled and never reads them in the initial implementation of subsetting.

Proposed change: in both cases if the flags param is set read flags raster. If not, don't. Keep it consistent for both calls.
@elidwa elidwa self-assigned this Sep 7, 2023
@elidwa
Copy link
Contributor Author

elidwa commented Sep 8, 2023

Fixed on subset branch.

@elidwa elidwa closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elidwa elidwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elidwa