Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws_s3_get for s3cache instead of aws transfer library #80

Closed
jpswinski opened this issue Aug 12, 2021 · 1 comment
Closed

Use aws_s3_get for s3cache instead of aws transfer library #80

jpswinski opened this issue Aug 12, 2021 · 1 comment

Comments

@jpswinski
Copy link
Member

The s3cache I/O driver currently uses the aws transfer library, but it should probably be replaced by a version of the much simpler aws_s3_get function used by Lua.

Performance tests will need to be run using both versions of the code. The advantage of not using the transfer library is that it will simplify the dependencies when building SlideRule. The aws_s3_get code is also a lot easier to understand.

@jpswinski
Copy link
Member Author

The S3CurlIODriver implements a aws-sdk-less get for S3 data and is now being used for the cache driver.

jpswinski added a commit that referenced this issue Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant