sliderule: update to EPSG:7912, use 3D Point geometry #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of the issues in #198
After some experimentation with latest PROJ (9.2.1) and GeoPandas, it appears that if we include 3D Point Geometries, we can do the 3D CRS transformations using the
to_crs()
functionality, since we now assign EPSG:7912 (3D CRS for ITRF2014 realization).This PR updates the default CRS for the Python client output (was inconsistent with what is returned by the server-side GeoRaster code). Also updated a few comments (EPSG:4326 is not MERCATOR), and fixed a typo.
There may be some unforeseen gotchas with the 3D Points, and we are preserving a redundant copy of the
h_mean
attribute as the Z coordinate in the Point, but I think this is acceptable. We don't want to drop theh_mean
column. An alternative would be to allow the user to specify whether they want a 2D or 3D Point geometry column for the GeoDataFrame.