Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Notification Class #38

Open
sankhaKarunasekara opened this issue Mar 18, 2020 · 0 comments
Open

Remove Deprecated Notification Class #38

sankhaKarunasekara opened this issue Mar 18, 2020 · 0 comments

Comments

@sankhaKarunasekara
Copy link
Contributor

File Name: FCMService.java

private Message.Builder getPreconfiguredMessageBuilder(PushNotificationRequest request) {
        AndroidConfig androidConfig = getAndroidConfig(request.getTopic());
        ApnsConfig apnsConfig = getApnsConfig(request.getTopic());
        return Message.builder()
                .setApnsConfig(apnsConfig).setAndroidConfig(androidConfig).setNotification(
                        new Notification(request.getTitle(), request.getMessage()));
    }

The Notification class in above method is deprecated, this method need to be replaced with more modern implementation.

good place to start: refer firebase-admin-java test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant