Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design changes in the new Edit Cell Dialogue #8366

Closed
N-thony opened this issue Jun 2, 2023 · 2 comments · Fixed by #8367
Closed

Design changes in the new Edit Cell Dialogue #8366

N-thony opened this issue Jun 2, 2023 · 2 comments · Fixed by #8367
Assignees

Comments

@N-thony
Copy link
Collaborator

N-thony commented Jun 2, 2023

@derekagorhom the new Edit does miss some of our properties while implementing a new dialogue. In the property the FormBorderStyle should be FixedToolWindow this won't allow user to expand the dialogue by dragging aside. Same time, can you align the controls well and make the space between them consistent? Also reduce the space at the top of the selector. See the screenshot below.
image

@N-thony N-thony changed the title Design changes in the new Edit Dialogue Design changes in the new Edit Cell Dialogue Jun 2, 2023
@rdstern
Copy link
Collaborator

rdstern commented Jul 2, 2023

@derekagorhom Two more things to fix in the edit cell dialog.

a) I opened survey and did some edits. All fine. Then I opened diamonds from the library and went to edit a cell in about row 300 in carat - the first column.
It gives me an error, because it has "remembered" that I used to be on the survey. So it is in the wrong place now. It should be in the right data frame too.
b) When you do Edit cell in row (say 300) it then returns to the top of the page - row 1 - at the end. I would like it to stay in the same place, so I see the new value.
c) For discussion also with @N-thony I would like to have a shortcut key - sort of like we use C for copy and X and V? This could be for both edit cell and delete cell. This seems to be the F2 key for edit cell and D for delete cells? Though I wonder we could consider E. That's for entering cell contents in Excel and I am not sure we will need that in R-Instat?

@N-thony
Copy link
Collaborator Author

N-thony commented Jul 5, 2023

@derekagorhom we can have a chat about item c) in few.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants