Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] iOS: footer template #2243

Closed
jfmcquade opened this issue Mar 18, 2024 · 5 comments · Fixed by #2281
Closed

[BUG] iOS: footer template #2243

jfmcquade opened this issue Mar 18, 2024 · 5 comments · Fixed by #2281
Labels
bug Something isn't working
Milestone

Comments

@jfmcquade
Copy link
Collaborator

Describe the bug
Follow-up to #2234

On iOS, the icons in the footer template disappear when navigating to some templates.

Screenshots and videos

Initial.emulation.mov
@jfmcquade jfmcquade added the bug Something isn't working label Mar 18, 2024
@jfmcquade jfmcquade added this to the iOS support milestone Mar 18, 2024
@chrismclarke
Copy link
Member

This might not just be an ios issue, but more devices with a notch (e.g. think pixel3a might have similar), usually related to how the code has been setup to handle safe-area views identified by the platform.

I'm not sure if this is something we've explicitly looked into in the past, I think the ionic nav-bar component automatically handles this but likely more work required for full layouts. A couple potentially useful links:

https://ionicframework.com/docs/theming/advanced#safe-area-padding
https://github.com/AlwaysLoveme/capacitor-plugin-safe-area

@jfmcquade
Copy link
Collaborator Author

Can confirm this issue is present on devices as well as simulators (tested on iPhone SE 3rd gen, iOS 17.3.1).

Seems to be an issue with webkit-* CSS variables, e.g. webkit-tap-highlight-color, applied to the icons in the a elements. But the behaviour in simulator is inconsistent when toggling these various style rules off and on: the same combination of style rules can leave the icons visible or not.

@chrismclarke
Copy link
Member

chrismclarke commented Apr 3, 2024

Just to check, is the issue also apparent on safari desktop or mobile browsers? Or only when running on device?

@jfmcquade
Copy link
Collaborator Author

Just to check, is the issue also apparent on safari desktop or mobile browsers? Or only when running on device?

Good question. I haven't been able to replicate on Safari on Desktop, but the issue is present on Safari on a (simulated) iOS device:

Screenshot 2024-04-04 at 15 51 47

I'm also now less confident that it's do with the webkit-* CSS variables, as it seems that toggling any unrelated CSS rule can fix the issue:

Screen.Recording.2024-04-04.at.15.54.10.mov

The fact it's present in Safari mobile does suggest I should possibly try researching the issue more broadly than as a Capacitor/Ionic issue

@chrismclarke
Copy link
Member

Might again be one for just hardcoding the color to 'white' as it seems to maybe not always be picked up correctly. Also could be worth trying to update ionic components to latest version in case any include fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants