Sourcery refactored main branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if is_exist: | ||
| return True | ||
| else: | ||
| return False | ||
| return bool(is_exist) |
There was a problem hiding this comment.
Function is_user_in_db refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-69
to
+66
| if is_exist: | ||
| return True | ||
| else: | ||
| return False | ||
| return bool(is_exist) |
There was a problem hiding this comment.
Function is_user_in_bdb refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-27
to
+30
| ''.join(["░" for i in range(20 - math.floor(percentage / 5))]), | ||
| round(percentage, 2)) | ||
| ''.join(["░" for _ in range(20 - math.floor(percentage / 5))]), | ||
| round(percentage, 2), | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function progress_for_pyrogram refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
Comment on lines
-26
to
+32
|
|
||
| elif query.data == "helpcallback": | ||
| await query.edit_message_text(text=Messages.HELP_TXT, reply_markup=Buttons.ME_GOIN_HOME) | ||
|
|
||
| elif query.data == "aboutcallback": | ||
| await query.edit_message_text(text=Messages.ABOUT_TXT, reply_markup=Buttons.ME_GOIN_HOME, disable_web_page_preview=True) | ||
|
|
There was a problem hiding this comment.
Function unzipper_cb refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if)
| ext_out = ext_cmd.stdout.read()[:-1].decode("utf-8") | ||
| return ext_out | ||
| return ext_cmd.stdout.read()[:-1].decode("utf-8") |
There was a problem hiding this comment.
Function __run_cmds_unzipper refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-32
to
+34
| if file_path == ".zst": | ||
| os.mkdir(path) | ||
| ex = await _extract_with_zstd(path, archive_path) | ||
| return ex | ||
| else: | ||
| ex = await _extract_with_7z_helper(path, archive_path, password) | ||
| return ex | ||
| if file_path != ".zst": | ||
| return await _extract_with_7z_helper(path, archive_path, password) | ||
| os.mkdir(path) | ||
| return await _extract_with_zstd(path, archive_path) |
There was a problem hiding this comment.
Function extr_files refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if) - Lift return into if (
lift-return-into-if) - Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-50
to
-63
| num = 0 | ||
| i_kbd = InlineKeyboard(row_width=1) | ||
| data = [] | ||
| data.append( | ||
| InlineKeyboardButton(f"Upload All ♻️", f"ext_a|{user_id}|{chat_id}") | ||
| ) | ||
| data = [InlineKeyboardButton('Upload All ♻️', f"ext_a|{user_id}|{chat_id}")] | ||
| data.append( | ||
| InlineKeyboardButton("Cancel ❌", "cancel_dis") | ||
| ) | ||
| for file in paths: | ||
| for num, file in enumerate(paths): | ||
| data.append( | ||
| InlineKeyboardButton(f"{num} - {os.path.basename(file)}", f"ext_f|{user_id}|{chat_id}|{num}") | ||
| ) | ||
| num += 1 |
There was a problem hiding this comment.
Function make_keyboard refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Merge append into list declaration (
merge-list-append) - Replace f-string with no interpolated values with string (
remove-redundant-fstring) - Replace manual loop counter with call to enumerate (
convert-to-enumerate)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.25%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!