Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegram update #54

Merged
merged 11 commits into from Dec 3, 2021
Merged

telegram update #54

merged 11 commits into from Dec 3, 2021

Conversation

zYxDevs
Copy link
Member

@zYxDevs zYxDevs commented Dec 3, 2021

  • sql migrate Integer to BigInteger
  • fix custom cmd handler error
  • fix indent
  • update app.json
  • update readme
  • afk: using f-string
  • Automate code formatting
  • merge pr #53

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 3, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 6.19 ⭐ 6.18 ⭐ -0.01 👍
Method Length 43.82 ⭐ 43.89 ⭐ 0.07 👎
Working memory 9.22 🙂 9.20 🙂 -0.02 👍
Quality 72.88% 🙂 72.91% 🙂 0.03% 👍
Other metrics Before After Change
Lines 2932 2928 -4
Changed files Quality Before Quality After Quality Change
zeldris/init.py 9.98% ⛔ 10.01% ⛔ 0.03% 👍
zeldris/modules/afk.py 57.17% 🙂 57.01% 🙂 -0.16% 👎
zeldris/modules/cleanblue.py 65.65% 🙂 65.65% 🙂 0.00%
zeldris/modules/helper_funcs/handlers.py 62.51% 🙂 62.51% 🙂 0.00%
zeldris/modules/sql/afk_sql.py 89.94% ⭐ 89.94% ⭐ 0.00%
zeldris/modules/sql/antiflood_sql.py 85.64% ⭐ 85.63% ⭐ -0.01% 👎
zeldris/modules/sql/connection_sql.py 74.74% 🙂 74.74% 🙂 0.00%
zeldris/modules/sql/feds_sql.py 73.74% 🙂 73.74% 🙂 0.00%
zeldris/modules/sql/global_bans_sql.py 89.69% ⭐ 89.69% ⭐ 0.00%
zeldris/modules/sql/reporting_sql.py 90.54% ⭐ 90.54% ⭐ 0.00%
zeldris/modules/sql/userinfo_sql.py 91.22% ⭐ 91.22% ⭐ 0.00%
zeldris/modules/sql/users_sql.py 85.65% ⭐ 85.65% ⭐ 0.00%
zeldris/modules/sql/warns_sql.py 82.90% ⭐ 82.90% ⭐ 0.00%
zeldris/modules/sql/welcome_sql.py 81.94% ⭐ 81.99% ⭐ 0.05% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zeldris/modules/afk.py reply_afk 26 😞 162 😞 17 ⛔ 29.95% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/sql/connection_sql.py add_history_conn 16 🙂 236 ⛔ 15 😞 33.28% 😞 Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/helper_funcs/handlers.py CustomCommandHandler.check_update 20 😞 147 😞 19 ⛔ 33.72% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/sql/feds_sql.py del_fed 24 😞 225 ⛔ 8 🙂 40.39% 😞 Refactor to reduce nesting. Try splitting into smaller methods
zeldris/modules/sql/feds_sql.py multi_fban_user 10 🙂 157 😞 15 😞 44.61% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@zYxDevs zYxDevs merged commit cdb7b40 into master Dec 3, 2021
@zYxDevs zYxDevs deleted the zeldrisdev branch December 3, 2021 12:21
@zYxDevs zYxDevs restored the zeldrisdev branch December 3, 2021 12:21
@zYxDevs
Copy link
Member Author

zYxDevs commented Dec 3, 2021

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants