Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that file extension of XHTML Content Doc in EPUB 3 is .xhtml #447

Closed
rdeltour opened this issue Sep 5, 2014 · 1 comment · Fixed by #454
Closed

Check that file extension of XHTML Content Doc in EPUB 3 is .xhtml #447

rdeltour opened this issue Sep 5, 2014 · 1 comment · Fixed by #454
Assignees
@rdeltour
Labels
type: improvement The issue suggests an improvement of an existing feature
Milestone
4.0

Comments

@rdeltour
Copy link
Member

rdeltour commented Sep 5, 2014

Currently, EpubChecks accepts either .html, .htm, .xhtml, with the same logic for both EPUB 2.0.1 and EPUB 3 (reported as HTML_014 if not the case).

EPUB 3 however says that the file extension of XHTML documents should be .xhtml.
@rdeltour rdeltour self-assigned this Sep 5, 2014
@rdeltour rdeltour added this to the 4.0 milestone Sep 5, 2014
rdeltour added a commit that referenced this issue Sep 8, 2014
@rdeltour
Check XHTML Content Doc extension in EPUB 3
599acdc 
  * make sure extension is '.xhtml', in `OPFChecker30`
  * remove duplicate `checkItem()` call in `OPFChecker`
  * Only report `HTM_014` for EPUB 2 (in `EpubHTML5StructureCheck`)
  * Add a new test for `HTM_014a`
  * Add a new test for `HTM_014`
  * Fix existing tests

Fixes #447
@rdeltour rdeltour mentioned this issue Sep 8, 2014
Merged
@santoch
Copy link

santoch commented Sep 8, 2014

LGTM

rdeltour added a commit that referenced this issue Sep 12, 2014
@rdeltour
Check XHTML Content Doc extension in EPUB 3
6fd290d 
  * make sure extension is '.xhtml', in `OPFChecker30`
  * remove duplicate `checkItem()` call in `OPFChecker`
  * Only report `HTM_014` for EPUB 2 (in `EpubHTML5StructureCheck`)
  * Add a new test for `HTM_014a`
  * Add a new test for `HTM_014`
  * Fix existing tests

Fixes #447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Check XHTML Content Docs extensions in EPUB 3 w3c/epubcheck
2 participants
@rdeltour @santoch