-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk:utils): add zIndex manager #1015
Conversation
This preview will be available after the AzureCI is passed. |
b362a75
to
7187e67
Compare
Codecov Report
@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 93.73% 93.75% +0.01%
==========================================
Files 313 314 +1
Lines 29922 29987 +65
Branches 3537 3540 +3
==========================================
+ Hits 28048 28113 +65
Misses 1874 1874
Continue to review full report at Codecov.
|
0f9c7c2
to
7cf1f1d
Compare
7cf1f1d
to
b3cec53
Compare
fc6807c
to
bfd4d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
销毁后,zIndex 不重置了?
bfd4d85
to
2d31c05
Compare
重置zIndex需要维护一份element的缓存,维护缓存会增加代码的负担。zIndex累加,从1000加到9999需要页面交互操作8999次,容错的数据足够大,理论上不会出现什么超过9999、超过zIndex最大值的问题。 |
2d31c05
to
61c3b9a
Compare
61c3b9a
to
00076ad
Compare
FIXED: #998
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
弹窗重叠时没有把zIndex加一
What is the new behavior?
modal会自动计算z-index, 后出现的弹窗会在前一个弹窗的基础上 z-index + 1
Other information