Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk:forms): setValue of AbstractControl supports triggering blur #1018

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  /**
   * Sets a new value for the control.
   *
   * @param value The new value.
   * @param options
   * * `dirty`: Marks it dirty, default is false.
   * * `blur`: Marks it blurred, default is false.
   */
  abstract setValue(value: T | Partial<T>, options?: { dirty?: boolean; blur?: boolean }): void

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1018 (353d5e5) into main (6f4d3af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   93.96%   93.97%           
=======================================
  Files         308      308           
  Lines       29249    29258    +9     
  Branches     2519     2521    +2     
=======================================
+ Hits        27485    27494    +9     
  Misses       1764     1764           
Impacted Files Coverage Δ
packages/components/input/src/useInput.ts 92.08% <ø> (-0.17%) ⬇️
packages/cdk/forms/src/controls.ts 100.00% <100.00%> (ø)
packages/cdk/forms/src/utils.ts 71.62% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4d3af...353d5e5. Read the comment docs.

@danranVm danranVm merged commit 8d38177 into IDuxFE:main Jul 14, 2022
@danranVm danranVm deleted the feat-cdk-forms-setValue branch July 14, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant