Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:notification): support contentProps (#1014) #1046

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

winchesHe
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

notification 支持 contentProps

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 27, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1046 (7588a4f) into main (70a6d4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7588a4f differs from pull request most recent head 14be50c. Consider uploading reports for the commit 14be50c to get more accurate results

@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files         314      314           
  Lines       29989    29995    +6     
  Branches     3541     3543    +2     
=======================================
+ Hits        28118    28124    +6     
  Misses       1871     1871           
Impacted Files Coverage Δ
...mponents/notification/src/NotificationProvider.tsx 98.74% <100.00%> (+0.02%) ⬆️
packages/components/notification/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a6d4a...14be50c. Read the comment docs.

@danranVm danranVm linked an issue Jul 28, 2022 that may be closed by this pull request
1 task
@winchesHe winchesHe changed the title feat(comp:notification): 支持 contentProps (#1014) feat(comp:notification): support contentProps (#1014) Jul 28, 2022
@danranVm danranVm merged commit 0057697 into IDuxFE:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:notification] 支持 contentProps
2 participants