Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:alert): cannot change pagination.pageindex through button #1102

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Sep 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

<template>
  <IxAlert :pagination="pagination">
    <div v-for="(item, index) in titles" :key="index">
      {{ item }}
    </div>
  </IxAlert>
</template>

<script lang="ts" setup>
import { reactive } from 'vue'

const titles = ['上次看到这句话的时候还是上次。', '上次看到这么无语的话,还是在上次。', '上次看到这么的发言还是上次。']

const pagination = reactive({
  pageIndex: 1,
  onChange: (index: number) => {
    pagination.pageIndex = index
  },
})
</script>

image

当设置了pagination.pageIndex,无法通过分页按钮切换,并且无法触发onChange

What is the new behavior?

修复正常

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 1, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1102 (f477161) into main (9e65136) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   96.95%   96.96%   +0.01%     
==========================================
  Files         321      321              
  Lines       30585    30596      +11     
  Branches     2809     2810       +1     
==========================================
+ Hits        29653    29667      +14     
+ Misses        932      929       -3     
Impacted Files Coverage Δ
packages/components/alert/src/Alert.tsx 100.00% <100.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 1669639 into IDuxFE:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants