Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locales): view the English text of all components #1115

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

wudu8
Copy link
Contributor

@wudu8 wudu8 commented Sep 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

为保证组件词条的专业性,检视并规范所有组件的内置词条

What is the new behavior?

为分页器组件新增了一个词条,原因是在检视英文词条的时候发现有pagination.totalSuffix这个词条被公用,但是这个词条不应该被公用,在翻译时也出现了冲突的情况,于是,新增了一个词条,将它分开

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 3, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #1115 (3017b0d) into main (ed08884) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         321      321           
  Lines       30624    30629    +5     
  Branches     2806     2806           
=======================================
+ Hits        29682    29687    +5     
  Misses        942      942           
Impacted Files Coverage Δ
packages/components/locales/src/types.ts 100.00% <100.00%> (ø)
packages/components/icon/src/dependencies.ts 99.05% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wudu8 wudu8 changed the title fix(packaging): view the English text of all components refactor(locales): view the English text of all components Sep 3, 2022
@danranVm danranVm merged commit 6e18697 into IDuxFE:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants