Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:*): container is supported for all overlay related components #1122

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Sep 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

fix #748
会影响所有的浮层组件。

What is the new behavior?

overlayContainer 支持全局配置,在特殊场景下,可以进行局部覆盖,让所有组件浮层组件生效。
例如,在 table 中所有的浮层都可以把 container 设置成 table 的 dom,

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 8, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1122 (6d30cd3) into main (96aa237) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 6d30cd3 differs from pull request most recent head 808f9db. Consider uploading reports for the commit 808f9db to get more accurate results

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   96.92%   96.79%   -0.13%     
==========================================
  Files         321      321              
  Lines       30627    30775     +148     
  Branches     2804     2800       -4     
==========================================
+ Hits        29685    29790     +105     
- Misses        942      985      +43     
Impacted Files Coverage Δ
packages/cdk/portal/src/Portal.tsx 100.00% <100.00%> (ø)
...ckages/components/_private/overlay/src/Overlay.tsx 100.00% <100.00%> (ø)
packages/components/_private/overlay/src/types.ts 100.00% <100.00%> (ø)
packages/components/cascader/src/Cascader.tsx 100.00% <100.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/drawer/src/Drawer.tsx 100.00% <100.00%> (ø)
packages/components/drawer/src/types.ts 100.00% <100.00%> (ø)
packages/components/dropdown/src/Dropdown.tsx 100.00% <100.00%> (ø)
packages/components/image/src/ImageViewer.tsx 100.00% <100.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit fe92709 into IDuxFE:main Sep 8, 2022
@danranVm danranVm deleted the feat-overlay-container branch September 8, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:*] 使用 container 替换 target
1 participant