Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:cascader): update overlay position after edging #1135

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

级联组件贴近浏览器边缘后,再打开下一级菜单,此时下一级菜单会到窗口外(看不见)。

What is the new behavior?

每次打开下一级菜单的时候,会更新一下 overlay 的位置,避免上述情况的出现。

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1135 (bea33dc) into main (7365dcc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         321      321           
  Lines       30824    30826    +2     
  Branches     2811     2811           
=======================================
+ Hits        29879    29881    +2     
  Misses        945      945           
Impacted Files Coverage Δ
packages/cdk/popper/src/types.ts 100.00% <100.00%> (ø)
packages/components/cascader/src/Cascader.tsx 100.00% <100.00%> (ø)
packages/components/cascader/src/token.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit ef352a8 into IDuxFE:main Sep 14, 2022
@danranVm danranVm deleted the fix-cascader-overlay branch September 14, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant