Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:icon): update viewBox of all icons #1146

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

将所有图标的 viewBox 调整未 0 0 1024 1024

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 15, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1146 (9212912) into main (c53309a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9212912 differs from pull request most recent head bf03c1b. Consider uploading reports for the commit bf03c1b to get more accurate results

@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         321      321           
  Lines       30826    30837   +11     
  Branches     2811     2813    +2     
=======================================
+ Hits        29881    29892   +11     
  Misses        945      945           
Impacted Files Coverage Δ
packages/components/icon/src/definitions.ts 100.00% <ø> (ø)
...es/components/popconfirm/src/PopconfirmContent.tsx 100.00% <100.00%> (ø)
packages/components/popconfirm/src/types.ts 100.00% <100.00%> (ø)
packages/components/transfer/src/types.ts 99.57% <100.00%> (+<0.01%) ⬆️
packages/pro/search/src/ProSearch.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 140aaac into IDuxFE:main Sep 16, 2022
@danranVm danranVm deleted the rebuild-icons branch September 16, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant