Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:scroll): virtual scroll scrolledBottom event #1148

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

sallerli1
Copy link
Contributor

scrolledBottom event shouldn't trigger when maxheight change

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

虚拟滚动的scrolledBottom在初始化以及高度改变时异常触发

What is the new behavior?

仅在滚动事件触发的前提下触发scrolledBottom事件

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1148 (185541f) into main (16c9df3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1148   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files         321      321           
  Lines       30878    30878           
  Branches     2066     2066           
=======================================
  Hits        29938    29938           
  Misses        940      940           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

scrolledBottom event shouldn't trigger when maxheight change
@sallerli1 sallerli1 force-pushed the fix-virtual-scroll-bottom-saller branch from a67625c to 185541f Compare September 22, 2022 11:39
@danranVm danranVm merged commit 64f1e07 into IDuxFE:main Sep 23, 2022
@sallerli1 sallerli1 deleted the fix-virtual-scroll-bottom-saller branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants