Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): prevent ok & cancel from triggering while animating #1190

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

在关闭过渡动画期间点击确定或者取消,会重复触发确定和取消事件

What is the new behavior?

修复以上问题

Other information

只有在visible为true时按钮点击触发对应回调

@idux-bot
Copy link

idux-bot bot commented Oct 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1190 (3c4d9fa) into next (da09bd5) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #1190      +/-   ##
==========================================
+ Coverage   96.63%   96.95%   +0.32%     
==========================================
  Files         317      318       +1     
  Lines       30953    30137     -816     
  Branches     2833     2786      -47     
==========================================
- Hits        29910    29218     -692     
+ Misses       1043      919     -124     
Impacted Files Coverage Δ
packages/components/modal/src/ModalWrapper.tsx 94.82% <100.00%> (+0.13%) ⬆️
packages/components/typography/src/typography.ts 58.33% <0.00%> (-41.67%) ⬇️
packages/components/tree-select/src/types.ts 99.31% <0.00%> (-0.16%) ⬇️
packages/components/tree/src/types.ts 99.65% <0.00%> (-0.04%) ⬇️
packages/components/drawer/src/DrawerWrapper.tsx 95.09% <0.00%> (-0.03%) ⬇️
packages/cdk/forms/src/types.ts 100.00% <0.00%> (ø)
packages/components/form/src/types.ts 100.00% <0.00%> (ø)
packages/components/menu/src/types.ts 100.00% <0.00%> (ø)
packages/components/image/src/types.ts 100.00% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit e207465 into IDuxFE:next Oct 10, 2022
@sallerli1 sallerli1 deleted the fix-modal-ok-cancel-saller branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants