Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): update modal content with update doesn't work #1270

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

调用 userModal 创建的 modalRef 的update 更新 content,无法触发更新

What is the new behavior?

修复以上问题

Other information

添加私有属性 __content_prop用来传递content

@idux-bot
Copy link

idux-bot bot commented Nov 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1270 (3cc98b4) into main (99e4ddd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         320      320           
  Lines       29469    29471    +2     
  Branches     3344     3345    +1     
=======================================
+ Hits        27422    27424    +2     
  Misses       2047     2047           
Impacted Files Coverage Δ
packages/components/modal/src/ModalBody.tsx 97.46% <100.00%> (ø)
packages/components/modal/src/ModalProvider.tsx 97.05% <100.00%> (-0.09%) ⬇️
packages/components/modal/src/types.ts 100.00% <100.00%> (ø)
packages/components/tree/src/Tree.tsx 95.13% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这种处理方式不是很优雅,不知道有没有更好的处理方案。

@danranVm danranVm merged commit 38f130a into IDuxFE:main Nov 15, 2022
@sallerli1 sallerli1 deleted the fix-use-modal-update-content branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants