Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:*): overlay destory on hide caused popper position error #1288

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

overlay destroyOnHide 之后,popper不再计算位置

What is the new behavior?

修复以上问题,在visible改变并且destroyOnHide 为true时重新初始化popper

Other information

@idux-bot
Copy link

idux-bot bot commented Nov 17, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #1288 (9ad058b) into main (67698a9) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   93.04%   93.03%   -0.01%     
==========================================
  Files         321      321              
  Lines       29730    29736       +6     
  Branches     3354     3356       +2     
==========================================
+ Hits        27661    27665       +4     
- Misses       2069     2071       +2     
Impacted Files Coverage Δ
...ckages/components/_private/overlay/src/Overlay.tsx 96.63% <71.42%> (-0.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brenner8023 brenner8023 self-requested a review November 18, 2022 08:31
@danranVm danranVm merged commit 0d5fe4e into IDuxFE:main Nov 21, 2022
@sallerli1 sallerli1 deleted the fix-overlay-destroy-on-hide branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants