Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:button): the radius of button group always hidden #1290

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 在 ButtonGroup 中的 border radius 被全部干掉了

What is the new behavior?

  • border radius 正常显示
  • class 名修改:ix-button-group-with-gap => ix-button-group-compact

Other information

@idux-bot
Copy link

idux-bot bot commented Nov 20, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #1290 (d7dcd5e) into main (5a9eb9d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files         321      321           
  Lines       29737    29737           
  Branches     3353     3353           
=======================================
  Hits        27668    27668           
  Misses       2069     2069           
Impacted Files Coverage Δ
packages/components/button/src/ButtonGroup.tsx 100.00% <100.00%> (ø)
packages/components/button/src/types.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 714f588 into IDuxFE:main Nov 21, 2022
@danranVm danranVm deleted the refactor-button-group branch November 21, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant