Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:button,checkbox,radio): add waveless prop #1303

Merged
merged 1 commit into from Dec 14, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Nov 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1303 (dda1faa) into main (84d0e66) will decrease coverage by 0.03%.
The diff coverage is 83.72%.

❗ Current head dda1faa differs from pull request most recent head 113f991. Consider uploading reports for the commit 113f991 to get more accurate results

@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   93.09%   93.06%   -0.04%     
==========================================
  Files         323      325       +2     
  Lines       29896    30045     +149     
  Branches     2465     3413     +948     
==========================================
+ Hits        27832    27960     +128     
- Misses       2064     2085      +21     
Impacted Files Coverage Δ
packages/components/_private/wave/src/Wave.tsx 64.91% <64.91%> (ø)
packages/components/button/src/Button.tsx 95.57% <91.66%> (-0.31%) ⬇️
packages/components/_private/wave/src/types.ts 100.00% <100.00%> (ø)
packages/components/button/src/types.ts 100.00% <100.00%> (ø)
packages/components/checkbox/src/Checkbox.tsx 98.03% <100.00%> (+0.14%) ⬆️
packages/components/checkbox/src/types.ts 100.00% <100.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/radio/src/Radio.tsx 94.32% <100.00%> (+0.44%) ⬆️
packages/components/radio/src/types.ts 100.00% <100.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@liuzaijiang liuzaijiang force-pushed the feat-button-lzj branch 4 times, most recently from a09cfaf to 83c596a Compare November 29, 2022 02:52
@liuzaijiang liuzaijiang force-pushed the feat-button-lzj branch 2 times, most recently from 3e79f7f to fcac857 Compare December 9, 2022 03:34
@danranVm danranVm merged commit 4881414 into IDuxFE:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants