Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pro:search): search btn triggers search change now #1321

Merged
merged 1 commit into from Dec 15, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

搜索图标点击不会触发搜索值修改,仅触发onSearch事件

What is the new behavior?

搜索图标点击先触发搜索值修改,再触发onSearch事件

Other information

业务线需求

@idux-bot
Copy link

idux-bot bot commented Dec 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1321 (0ba1799) into main (84d0e66) will decrease coverage by 0.11%.
The diff coverage is 17.85%.

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   93.09%   92.97%   -0.12%     
==========================================
  Files         323      322       -1     
  Lines       29896    29666     -230     
  Branches     2465     2461       -4     
==========================================
- Hits        27832    27583     -249     
- Misses       2064     2083      +19     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 16.41% <11.53%> (-0.81%) ⬇️
packages/pro/search/src/token.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sallerli1 sallerli1 force-pushed the feat-pro-search-trigger-search branch from 68743b3 to a12d2d0 Compare December 2, 2022 07:46
@sallerli1 sallerli1 force-pushed the feat-pro-search-trigger-search branch from a12d2d0 to 0ba1799 Compare December 14, 2022 02:47
@danranVm danranVm merged commit e44673f into IDuxFE:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants