Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:table): the sorter should not be triggered on resize end #1324

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Dec 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 同时开始 sortable, resizable, 在拖拽结束时会触发排序

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1324 (e394544) into main (145865c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
- Coverage   93.13%   93.13%   -0.01%     
==========================================
  Files         324      324              
  Lines       29981    29972       -9     
  Branches     3399     3399              
==========================================
- Hits        27924    27915       -9     
  Misses       2057     2057              
Impacted Files Coverage Δ
packages/components/tooltip/src/types.ts 100.00% <0.00%> (ø)
packages/components/popconfirm/src/token.ts 100.00% <0.00%> (ø)
packages/components/popover/src/Popover.tsx 100.00% <0.00%> (ø)
...es/components/popconfirm/src/PopconfirmContent.tsx 100.00% <0.00%> (ø)
...ckages/components/_private/overlay/src/Overlay.tsx 95.54% <0.00%> (+0.01%) ⬆️
...ckages/components/tooltip/src/useTooltipOverlay.ts 93.75% <0.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 57c5a7f into IDuxFE:main Dec 2, 2022
@danranVm danranVm deleted the fix-pro-table-resizable branch December 2, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant