Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:upload): customRequest allows optional abort handling and async #1340

Merged
merged 1 commit into from Dec 9, 2022

Conversation

typistZxd
Copy link
Member

@typistZxd typistZxd commented Dec 6, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

customRequest 不支持async,同时返回值类型强制要求包含abort,约束比较大

What is the new behavior?

customRequest 支持async,返回值abort是可选的

image

Other information

@danranVm

@idux-bot
Copy link

idux-bot bot commented Dec 6, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1340 (4e978ce) into main (a4ba26a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   93.12%   93.11%   -0.01%     
==========================================
  Files         323      323              
  Lines       29903    29918      +15     
  Branches     3391     3395       +4     
==========================================
+ Hits        27847    27858      +11     
- Misses       2056     2060       +4     
Impacted Files Coverage Δ
packages/components/upload/src/types.ts 100.00% <100.00%> (ø)
packages/cdk/portal/src/Portal.tsx 91.56% <0.00%> (-4.82%) ⬇️
packages/pro/search/src/types.ts 100.00% <0.00%> (ø)
packages/components/config/src/types.ts 100.00% <0.00%> (ø)
packages/components/utils/src/portalTarget.ts 100.00% <0.00%> (ø)
...ckages/components/_private/overlay/src/Overlay.tsx 95.60% <0.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@typistZxd typistZxd changed the title WIP: fix(comp:upload): customRequest allows optional and async fix(comp:upload): customRequest allows optional and async Dec 7, 2022
@danranVm danranVm merged commit 52250a5 into IDuxFE:main Dec 9, 2022
@typistZxd typistZxd changed the title fix(comp:upload): customRequest allows optional and async fix(comp:upload): customRequest allows optional abort handling and async Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants