Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:*): opening overlay once triggers two zIndex changes #1355

Merged
merged 1 commit into from Dec 14, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 打开一次浮层组件,会调用两次的 useZIndex

What is the new behavior?

  • 修复上面的问题,同时把浮层的 id 前缀从 overlay 改成了 __IDUX_OVERLAY

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 13, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1355 (6f56f32) into main (031834e) will decrease coverage by 0.00%.
The diff coverage is 91.42%.

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   93.10%   93.09%   -0.01%     
==========================================
  Files         323      323              
  Lines       29917    29896      -21     
  Branches     3397     3392       -5     
==========================================
- Hits        27853    27832      -21     
  Misses       2064     2064              
Impacted Files Coverage Δ
packages/components/dropdown/src/Dropdown.tsx 59.37% <0.00%> (-0.63%) ⬇️
packages/components/popconfirm/src/Popconfirm.tsx 100.00% <ø> (ø)
packages/pro/search/src/ProSearch.tsx 17.22% <0.00%> (ø)
...ckages/components/_private/overlay/src/Overlay.tsx 95.60% <100.00%> (+0.05%) ⬆️
packages/components/_private/overlay/src/types.ts 100.00% <100.00%> (ø)
packages/components/cascader/src/Cascader.tsx 95.85% <100.00%> (ø)
packages/components/popover/src/Popover.tsx 100.00% <100.00%> (ø)
packages/components/select/src/Select.tsx 87.06% <100.00%> (-0.06%) ⬇️
packages/components/tooltip/src/Tooltip.tsx 100.00% <100.00%> (ø)
...ckages/components/tooltip/src/useTooltipOverlay.ts 93.33% <100.00%> (-0.42%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 7cec4ec into IDuxFE:main Dec 14, 2022
@danranVm danranVm deleted the fix-overlay-zIndex branch December 14, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant