Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): zIndex should be updated only when focused change #1356

Merged
merged 1 commit into from Dec 15, 2022

Conversation

sallerli1
Copy link
Contributor

@sallerli1 sallerli1 commented Dec 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

proSearch的z-index计算不正确,应当只在focused(即激活)时更新zIndex

What is the new behavior?

渲染时就默认更新了zIndex,引发了渲染在弹窗开启之后而导致的zIndex异常
image

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1356 (5b4bdcd) into main (84d0e66) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         323      323           
  Lines       29896    29895    -1     
  Branches     2465     2465           
=======================================
  Hits        27832    27832           
+ Misses       2064     2063    -1     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 17.31% <0.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 61a51fd into IDuxFE:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants