Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): searchItem mousedown doesn't trigger focused #1368

Merged
merged 1 commit into from Dec 23, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

点击搜索项没有触发focus
overlayContainer的dom查找不正确

What is the new behavior?

修复以上问题

Other information

display:none导致元素内的focus事件不能正常触发,隐藏样式修改为使用 height:0;width:0;opacity:0 实现
加入了overlayContainerFallback之后没有调整overlay容器Dom获取计算

@idux-bot
Copy link

idux-bot bot commented Dec 20, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1368 (667a8a1) into main (f90d791) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
- Coverage   92.92%   92.89%   -0.04%     
==========================================
  Files         324      324              
  Lines       29827    29838      +11     
  Branches     2474     2474              
==========================================
  Hits        27718    27718              
- Misses       2109     2120      +11     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 15.63% <0.00%> (-0.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 14637be into IDuxFE:main Dec 23, 2022
@sallerli1 sallerli1 deleted the fix-pro-search-active-focus branch February 20, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants