Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): incorrect serial number #1370

Merged
merged 1 commit into from Dec 23, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Dec 23, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 序号列的序号计算不正确

What is the new behavior?

  • 按照分页的算法去计算序号。
  • 普通Table 也支持序号列。

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 23, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #1370 (04bff04) into main (f90d791) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
- Coverage   92.92%   92.89%   -0.04%     
==========================================
  Files         324      324              
  Lines       29827    29850      +23     
  Branches     2474     2474              
==========================================
+ Hits        27718    27730      +12     
- Misses       2109     2120      +11     
Impacted Files Coverage Δ
packages/pro/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/table/src/types.ts 100.00% <100.00%> (ø)
packages/pro/config/src/types.ts 100.00% <100.00%> (ø)
packages/pro/search/src/ProSearch.tsx 15.63% <0.00%> (-0.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit f19efbe into IDuxFE:main Dec 23, 2022
@danranVm danranVm deleted the fix-table-indexable branch December 23, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant