Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): reading contains after onmounted causes an exception #1371

Merged
merged 1 commit into from Dec 23, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 动画还未结束前就销毁了组件(例如:路由发生改变),会产生报错。
    image

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 23, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #1371 (48be1a0) into main (f19efbe) will not change coverage.
The diff coverage is 26.66%.

@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         324      324           
  Lines       29850    29850           
  Branches     2474     2474           
=======================================
  Hits        27730    27730           
  Misses       2120     2120           
Impacted Files Coverage Δ
packages/components/drawer/src/DrawerWrapper.tsx 83.12% <25.00%> (ø)
packages/components/modal/src/ModalWrapper.tsx 79.15% <28.57%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit de416c1 into IDuxFE:main Dec 23, 2022
@danranVm danranVm deleted the fix-modal-container branch December 23, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant