Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): sort and filter not work with async columns #1376

Merged
merged 1 commit into from Dec 26, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • vue2 的版本在异步获取 columns 时,sorter 和 filter 不能正常工作。

What is the new behavior?

  • 兼容 vue2 的版本

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 26, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1376 (b6db918) into main (8dbee09) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   92.89%   92.86%   -0.03%     
==========================================
  Files         324      324              
  Lines       29851    29845       -6     
  Branches     2474     2474              
==========================================
- Hits        27730    27717      -13     
- Misses       2121     2128       +7     
Impacted Files Coverage Δ
packages/components/dropdown/src/Dropdown.tsx 40.00% <0.00%> (-19.38%) ⬇️
packages/components/cascader/src/Cascader.tsx 95.87% <0.00%> (+0.02%) ⬆️
packages/components/tree-select/src/TreeSelect.tsx 95.47% <0.00%> (+0.02%) ⬆️
packages/components/select/src/Select.tsx 87.12% <0.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 9163d69 into IDuxFE:main Dec 26, 2022
@danranVm danranVm deleted the fix-table-async-columns branch December 26, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant