Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): can't select other options when there are input values #1387

Merged
merged 1 commit into from Jan 6, 2023

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

当有输入值时,无法选中其他选项

GIF 2023-1-4 18-42-05

What is the new behavior?

  1. 修复以上问题
  2. 增加键盘删除功能

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 4, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #1387 (20248b8) into main (cb97fd0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   92.86%   92.87%           
=======================================
  Files         324      324           
  Lines       29845    29818   -27     
  Branches     2474     2481    +7     
=======================================
- Hits        27717    27694   -23     
+ Misses       2128     2124    -4     
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 87.34% <100.00%> (+0.21%) ⬆️
packages/components/config/src/types.ts 100.00% <0.00%> (ø)
packages/components/progress/src/Line.tsx 100.00% <0.00%> (ø)
packages/components/progress/src/tokens.ts 100.00% <0.00%> (ø)
packages/components/progress/src/Circle.tsx 100.00% <0.00%> (ø)
packages/components/progress/src/Progress.tsx 100.00% <0.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <0.00%> (ø)
packages/components/progress/src/ProgressInfo.tsx 97.18% <0.00%> (+0.08%) ⬆️
...ckages/components/_private/overlay/src/Overlay.tsx 96.68% <0.00%> (+1.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  const handleOptionClick = (option: SelectData) => {
      changeSelected(getKey.value(option))
      if (props.multiple) {
        clearInput()
      } else {
        props.allowInput && clearInput()
        setOverlayOpened(false)
      }
    }

这个地方不是需要加一下这个吗?

@liuzaijiang
Copy link
Contributor Author

  const handleOptionClick = (option: SelectData) => {
      changeSelected(getKey.value(option))
      if (props.multiple) {
        clearInput()
      } else {
        props.allowInput && clearInput()
        setOverlayOpened(false)
      }
    }

这个地方不是需要加一下这个吗?

已加

@danranVm danranVm merged commit 59fc80e into IDuxFE:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants