Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:tree): correct param checked of onCheck #1404

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

sallerli1
Copy link
Contributor

checked should be the state of check operation instead of state of node

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

节点处于半选状态时,onCheck 的 checked 参数 始终是 true

What is the new behavior?

onCheck 的 checked 参数应当为当前操作的状态,即使节点处于半选状态, checked 也应当变化

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 12, 2023

This preview will be available after the AzureCI is passed.

`checked` should  be the state of check operation instead of state of node
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1404 (05b9af8) into main (5d604f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1404   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         325      325           
  Lines       29930    29930           
  Branches     2495     2495           
=======================================
  Hits        27805    27805           
  Misses       2125     2125           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 2858da6 into IDuxFE:main Jan 13, 2023
sallerli1 added a commit to sallerli1/idux that referenced this pull request Jan 13, 2023
`checked` should  be the state of check operation instead of state of node
@sallerli1 sallerli1 deleted the fix-tree-on-check-checked branch February 20, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants