Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:cascader): add disableData to dynamically disable options #1408

Merged
merged 2 commits into from Jan 13, 2023

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jan 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

image

image

父节点被禁用的情况下还能被搜索到

What is the new behavior?

  • 新增 disableData 来支持动态的禁用选项
  • 新增 separator 用于自定义分隔符
  • 修复上禁用还能被搜索到的bug

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 12, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1408 (7c15980) into main (5d604f9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c15980 differs from pull request most recent head 8ce11e9. Consider uploading reports for the commit 8ce11e9 to get more accurate results

@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         325      326    +1     
  Lines       29930    29966   +36     
  Branches     2495     2498    +3     
=======================================
+ Hits        27805    27841   +36     
  Misses       2125     2125           
Impacted Files Coverage Δ
packages/components/cascader/src/Cascader.tsx 96.07% <100.00%> (+0.20%) ⬆️
packages/components/cascader/src/token.ts 100.00% <100.00%> (ø)
packages/components/cascader/src/types.ts 100.00% <100.00%> (ø)
packages/components/utils/src/useDisabled.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 65328e7 into IDuxFE:main Jan 13, 2023
@danranVm danranVm deleted the feat-cascader-disableData branch January 13, 2023 03:03
sallerli1 pushed a commit to sallerli1/idux that referenced this pull request Jan 13, 2023
…DuxFE#1408)

* feat(comp:cascader): add disableData to dynamically disable options

* feat(comp:cascader): add separator prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant