Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:rate): add color prop for rate #1420

Merged
merged 2 commits into from Feb 21, 2023
Merged

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Jan 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 16, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #1420 (65826d3) into main (0612164) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   92.80%   92.81%           
=======================================
  Files         327      327           
  Lines       30292    30298    +6     
  Branches     2541     2541           
=======================================
+ Hits        28114    28120    +6     
  Misses       2178     2178           
Impacted Files Coverage Δ
packages/components/rate/src/Rate.tsx 76.50% <100.00%> (+0.14%) ⬆️
packages/components/rate/src/RateItem.tsx 94.28% <100.00%> (ø)
packages/components/rate/src/types.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 挂了,需要修复一下测试,也是测试快照的问题,你更新了 Dom

@danranVm danranVm changed the base branch from main to feature February 21, 2023 11:42
@danranVm danranVm merged commit 5b78ee6 into IDuxFE:feature Feb 21, 2023
danranVm pushed a commit that referenced this pull request Feb 27, 2023
* feat(comp:rate): add color prop for rate

* test(comp:rate): update snapshot
danranVm pushed a commit that referenced this pull request Feb 27, 2023
* feat(comp:rate): add color prop for rate

* test(comp:rate): update snapshot
@kovsu kovsu deleted the rate branch March 10, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants