Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): blur event make span render bad #1437

Merged
merged 2 commits into from Feb 8, 2023

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Jan 25, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

fix #1431

正常显示:
image

错误显示:
image

可以发现,错误显示的原因就是没有渲染 ix-selector-item 这个盒子

image

错误情况下丢失焦点,inputValue.value 是有的,所以 !inputValue.value 就为 false,导致 item 没有渲染

@idux-bot
Copy link

idux-bot bot commented Jan 25, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #1437 (64fce3f) into main (caf4dbf) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
- Coverage   92.80%   92.80%   -0.01%     
==========================================
  Files         327      327              
  Lines       30292    30298       +6     
  Branches     2541     2542       +1     
==========================================
+ Hits        28114    28117       +3     
- Misses       2178     2181       +3     
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 86.41% <57.14%> (-0.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit b15fedd into IDuxFE:main Feb 8, 2023
@kovsu kovsu deleted the select-allow-input branch February 8, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:select] 下拉选择器在输入时鼠标失焦后输入内容被清空了
2 participants