feat(comp:select): add loading prop for select component
#1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
kovsu
changed the title
loading prop for select componentloading prop for select component
Codecov Report
@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
+ Coverage 92.80% 92.98% +0.17%
==========================================
Files 327 327
Lines 30292 30361 +69
Branches 2541 2561 +20
==========================================
+ Hits 28114 28232 +118
+ Misses 2178 2129 -49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danranVm
requested changes
Feb 13, 2023
kovsu
force-pushed
the
select-loading
branch
from
1afd8b1
to
ebf8fb5
Compare
|
不建议在面板上加loading，可以加在外部 content 组件上面，面板仅仅是数据展示，耦合太多功能会影响后续扩展问题。 比如以下场景，这样的写法可能没有办法兼容：
另外，loading是需要考虑自定义 spin 配置的，可以参考一下其他组件的 spin 写法 |
kovsu
force-pushed
the
select-loading
branch
from
11239b6
to
998a681
Compare
danranVm
requested changes
Feb 15, 2023
| @@ -107,7 +108,13 @@ export default defineComponent({ | |||
| } | |||
| } | |||
|
|
|||
| const handleBlur = () => accessor.markAsBlurred() | |||
| const handleBlur = () => { | |||
There was a problem hiding this comment.
这个地方还是没有正确 rebase 哈，你需要先在 main 分支 pull 一下最新代码，再切换到 select-loading 分支做一次rebase
| @@ -37,6 +37,7 @@ | |||
| | `status` | 手动指定校验状态 | `valid \| invalid \| validating` | - | - | - | | |||
| | `suffix` | 设置后缀图标 | `string \| #suffix` | `down` | ✅ | - | | |||
| | `virtual` | 是否开启虚拟滚动 | `boolean` | `false` | - | - | | |||
| | `loading` | 是否显示加载中状态 | `boolean \| SpinPublicProps` | `false` | - | - | | |||
There was a problem hiding this comment.
这个直接改成 spin 吧， 跟 table 直接保持一致，默认值为 undefined
然后注意下 API 顺序，按照字母顺序排下序
Comment on lines
171
to
179
| const { loading } = props | ||
| if (!loading) { | ||
| return children | ||
| } | ||
| if (typeof loading === 'boolean') { | ||
| return <IxSpin>{children}</IxSpin> | ||
| } else { | ||
| return <IxSpin {...loading}>{children}</IxSpin> | ||
| } |
There was a problem hiding this comment.
Suggested change
| const { loading } = props | |
| if (!loading) { | |
| return children | |
| } | |
| if (typeof loading === 'boolean') { | |
| return <IxSpin>{children}</IxSpin> | |
| } else { | |
| return <IxSpin {...loading}>{children}</IxSpin> | |
| } | |
| const { spin } = props | |
| const spinProps = isBoolean(spin) ? { spinning: spin } : spin | |
| return spinProps ? <IxSpin {...spinProps }>{children}</IxSpin> : children |
| @@ -12,6 +12,7 @@ import type { VirtualScrollToFn } from '@idux/cdk/scroll' | |||
| import type { ExtractInnerPropTypes, ExtractPublicPropTypes, MaybeArray, VKey } from '@idux/cdk/utils' | |||
| import type { EmptyProps } from '@idux/components/empty' | |||
| import type { FormSize } from '@idux/components/form' | |||
| import type { SpinPublicProps } from '@idux/components/spin/src/types' | |||
There was a problem hiding this comment.
Suggested change
| import type { SpinPublicProps } from '@idux/components/spin/src/types' | |
| import type { SpinProps } from '@idux/components/spin' |
| @@ -80,6 +81,7 @@ export const selectProps = { | |||
| status: String as PropType<ValidateStatus>, | |||
| suffix: { type: String, default: undefined }, | |||
| virtual: { type: Boolean, default: false }, | |||
| loading: { type: [Boolean, Object] as PropType<boolean | SpinPublicProps>, default: false }, | |||
There was a problem hiding this comment.
Suggested change
| loading: { type: [Boolean, Object] as PropType<boolean | SpinPublicProps>, default: false }, | |
| spin: { type: [Boolean, Object] as PropType<boolean | SpinProps >, default: undefined }, |
kovsu
force-pushed
the
select-loading
branch
from
fcdd0f8
to
77cce6c
Compare
danranVm
pushed a commit
that referenced
this pull request
Feb 27, 2023
* feat(comp:select): add loading prop * fix(comp:select): spin type in api doc
danranVm
pushed a commit
that referenced
this pull request
Feb 27, 2023
* feat(comp:select): add loading prop * fix(comp:select): spin type in api doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
fix #1435
What is the new behavior?
Other information