Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): call blur after 'enter' envent #1441

Merged
merged 1 commit into from Feb 13, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 在可输入模式下,输入内容后,按下回车键,会保存输入的内容。
  • 再一次按下回车键,会把内容重置为第一个选项的值。

select

What is the new behavior?

  • 单选模式下,按下回车后,触发 blur 事件,来规避上面的问题。

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1441 (f5ed0d5) into main (7829ca1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   92.81%   92.84%   +0.03%     
==========================================
  Files         327      327              
  Lines       30349    30350       +1     
  Branches     2546     2549       +3     
==========================================
+ Hits        28168    28179      +11     
+ Misses       2181     2171      -10     
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 86.47% <100.00%> (+0.05%) ⬆️
packages/cdk/a11y/src/focusMonitor.ts 91.59% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 391c526 into IDuxFE:main Feb 13, 2023
@danranVm danranVm deleted the fix-select-blur branch February 13, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant