Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): treeSelect panel height is unset #1445

Merged
merged 1 commit into from Feb 15, 2023

Conversation

sallerli1
Copy link
Contributor

add height prop and fix it to 256 so that treeSelect panel wont be too high

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

treeSelect 类型面板没有设置高度,会导致超长

What is the new behavior?

暂时固定高度为 256px,和目前的 select 面板一致,后续考虑是否要增加可配置

Other information

add `height` prop and fix it to `256` so that `treeSelect` panel wont be too high
@idux-bot
Copy link

idux-bot bot commented Feb 13, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1445 (f709e89) into main (8852db4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1445   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         327      327           
  Lines       30350    30350           
  Branches     2559     2560    +1     
=======================================
  Hits        28221    28221           
  Misses       2129     2129           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 388da6a into IDuxFE:main Feb 15, 2023
@sallerli1 sallerli1 deleted the fix-pro-search-tree-height branch February 20, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants