Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:carousel): when items is dynamically reduced to 1, layout error #1450

Merged
merged 1 commit into from Feb 16, 2023

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

<template>
  <IxCarousel>
    <div v-for="page in pageSizes">
      <div class="card-item">远看泰山黑糊糊</div>
    </div>
  </IxCarousel>
  <IxButton @click="pageSizes = 1">减少数量</IxButton>
</template>

<script lang="ts" setup>
import { ref } from 'vue'

const pageSizes = ref(3)

</script>

<style lang="less" scoped>
.card-item {
  height: 160px;
  line-height: 160px;
  background-color: #364d79;
  text-align: center;
  font-size: 16px;
  color: #fff;
}
</style>

GIF 2023-2-16 16-42-50

What is the new behavior?

GIF 2023-2-16 16-44-09

Other information

新增getCssDimensions精确获取元素宽高

@idux-bot
Copy link

idux-bot bot commented Feb 16, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1450 (6d3a26f) into main (388da6a) will decrease coverage by 0.06%.
The diff coverage is 18.18%.

❗ Current head 6d3a26f differs from pull request most recent head 7d06e0f. Consider uploading reports for the commit 7d06e0f to get more accurate results

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   92.98%   92.93%   -0.06%     
==========================================
  Files         327      327              
  Lines       30350    30372      +22     
  Branches     2560     2560              
==========================================
+ Hits        28221    28225       +4     
- Misses       2129     2147      +18     
Impacted Files Coverage Δ
packages/cdk/utils/src/dom.ts 78.97% <18.18%> (-8.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 2e37c44 into IDuxFE:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants