fix(comp:upload): upload list card status text isn't centered #1461
Conversation
|
This preview will be available after the AzureCI is passed. |
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| p { | ||
| font-size: 14px; | ||
| margin: 8px 0 0 0; | ||
| } | ||
| } | ||
| </style> |
There was a problem hiding this comment.
with the code review
The code looks generally fine and there are no major bugs. The only suggestion I could make is to ensure that the font size for the
element is consistent with other elements in the style sheet. You should also consider adding a few more attributes such as line height and font family to ensure a better visual presentation.
| min-width: @upload-list-image-card-status-min-width; | ||
|
|
||
| .@{idux-prefix}-progress { | ||
| display: flex; | ||
| margin-top: @upload-list-image-card-status-progress-margin; | ||
| margin: @upload-list-image-card-status-progress-margin; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
with a brief code review:
-
The new code adds a 'text-align: center;' and 'padding: @spacing-xs;' to the '.@{upload-prefix}-status' class. This is good, as it makes the text in the status box more readable, and adds some padding around the edges.
-
The new code also changes the 'margin-top' of the '.@{idux-prefix}-progress' class from '@upload-list-image-card-status-progress-margin' to '@upload-list-image-card-status-progress-margin'. This is good, as it will make the margins more consistent across the different elements in the card.
-
There are no obvious bugs or issues with the code, so no further changes are necessary.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
修复以上问题
Other information