Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:spin): spin container blured opacity should be 0.3 #1464

Merged
merged 1 commit into from Feb 23, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

加载中的容器透明度为0.7

What is the new behavior?

应当是不透明度是0.7,即透明度0.3

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 22, 2023

This preview will be available after the AzureCI is passed.

@@ -81,7 +81,7 @@
transition: opacity @transition-duration-base;

&-blur {
opacity: 0.7;
opacity: 0.3;
user-select: none;
clear: both;
overflow: hidden;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code patch is used to change the value of the opacity from 0.7 to 0.3 for the &-blur class.

It looks like there are no bugs in the code patch, but there may be potential risks with making this change. Depending on how and where the &-blur class is used, a lower opacity might affect the user experience negatively. For example, if it is used on text, it could be hard to read. It's important to test out the changes to make sure they don't negatively impact the user experience.

Another suggestion is to use a variable to store the opacity value, so that it can easily be changed if needed. This way, you won't have to search through the codebase to find the class when you need to adjust the opacity.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1464 (439712d) into main (f870a84) will not change coverage.
The diff coverage is n/a.

❗ Current head 439712d differs from pull request most recent head afe0252. Consider uploading reports for the commit afe0252 to get more accurate results

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         327      327           
  Lines       30399    30399           
  Branches     3495     3495           
=======================================
  Hits        28193    28193           
  Misses       2206     2206           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit f88ad9a into IDuxFE:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants