fix(comp:table): virtual + fixed column abnormal display with chrome83 #1473
Conversation
|
This preview will be available after the AzureCI is passed. |
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| // chrome 83: virtual + fixed column | ||
| .cdk-virtual-scroll-content { | ||
| display: block; | ||
| } | ||
| } |
There was a problem hiding this comment.
with the code review:
-
The first patch changes the background color of the table rows when they are hovered over. This should improve user experience and make the table more visually appealing.
-
The second patch adds some code to enable support for Chrome version 83 which includes virtual and fixed column support. This should improve the compatibility of the table with the latest versions of Chrome.
Codecov Report
@@ Coverage Diff @@
## main #1473 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 327 327
Lines 30426 30426
Branches 3497 3497
=======================================
Hits 28219 28219
Misses 2207 2207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| <IxRadio {...(trigger ? exitTriggerRadioProps : radioProps)}></IxRadio> | ||
| ) | ||
| const radioProps = { checked, disabled, onChange, onClick } | ||
| return customRender ? customRender(radioProps) : <IxRadio {...radioProps}></IxRadio> | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
the brief code review:
The patch looks good, overall. It appears that the code is removing the unnecessary "handleClick" function and replacing it with an "onClick" function that includes the additional logic of allowing for radio selection reversal when clicked multiple times. This is a good improvement and should not introduce any bugs.
There are a few minor things to consider for further improvement, however. Firstly, the code could be made more concise by using a ternary operator instead of an if-else statement for the "multiple" condition. Additionally, the logic for the "trigger" variable may still need to be considered, as it doesn't appear to be used in the code, even though it is declared.
| @@ -125,7 +125,7 @@ exports[`TreeSelect > single work > searchable work 2`] = ` | |||
| <!----> | |||
| </div> | |||
| <div class=\\"ix-selector-suffix\\"><i class=\\"ix-icon ix-icon-down\\" style=\\"transform: rotate(180deg);\\" role=\\"img\\" aria-label=\\"down\\"><svg viewBox=\\"0 0 1024 1024\\" focusable=\\"false\\" aria-hidden=\\"true\\" data-icon=\\"down\\"> | |||
| <path d=\\"m294.784 411.776 208.192 208.192a12.8 12.8 0 0 0 18.048 0l208.192-208.192a12.8 12.8 0 0 1 18.112 0l27.136 27.2a12.8 12.8 0 0 1 0 18.048l-253.44 253.44a12.8 12.8 0 0 1-18.048 0l-253.44-253.44a12.8 12.8 0 0 1 0-18.048l27.136-27.2a12.8 12.8 0 0 1 18.112 0z\\"></path> | |||
| <path d=\\"m294.777 395.325 208.172 208.172c4.999 5 13.103 5 18.102 0l208.172-208.172c4.999-4.999 13.103-4.999 18.102 0l27.153 27.153c4.999 4.999 4.999 13.103 0 18.102L521.051 694.007c-4.999 4.999-13.103 4.999-18.102 0L249.522 440.58c-4.999-4.999-4.999-13.103 0-18.102l27.153-27.153c4.999-4.999 13.103-4.999 18.102 0Z\\"></path> | |||
| </svg></i></div> | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
the code review:
The code patch looks like it is making some changes to a tree selector in the codebase. The first thing that can be noticed is the change in the path attribute of the SVG element. It looks like the old path was changed with a new one and the coordinates were adjusted. This could be a fix to improve the visual look of the selector or make it more efficient.
It is also possible to suggest some improvements to this code. It would be good to add checks for whether the new coordinates are valid or not, as it could cause issues if the new coordinates are invalid. This can be done by adding an if condition before the change is made to ensure it is valid. Additionally, it would be beneficial to add comments to explain the purpose of the change, which will make it easier for future developers to understand the code.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
内网 issue 118，173
What is the new behavior?
Other information