fix(comp:table): the indent not work and selected records not cached

[danranVm]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines
• Tests for the changes have been added/updated or not needed
• Docs and demo have been added/updated or not needed

What is the current behavior?

• 展开列叶子节点的 indent 配置不生效
• 对于后端分页的场景，已经选中的数据，再切换页面后，没有被缓存，onChange 回调的数据中丢失。

What is the new behavior?

Other information

[cr-gpt]

with the code review.

First, I would check that the type of the column is set correctly to 'selectable'. It should be set to 'selectable' and not 'text' or any other value.

Second, I would check that the alignment is set correctly to 'center'. This will ensure that the column is aligned correctly.

Third, I would check that the multiple value is set correctly to 'true'. This will allow users to select multiple rows in the table.

Fourth, I would check that the showIndex is set correctly to 'false'. This will prevent the index being displayed when selecting multiple rows.

Fifth, I would check that the onChange value is set correctly to 'console.log'. This will log all changes made on the table.

Finally, I would check that no other columns are affected by this change. That is, any other columns should remain unchanged.

I hope this helps. Please let me know if you have any questions.

[idux-bot]

This preview will be available after the AzureCI is passed.

[cr-gpt]

with the code review:

1. The indent value for the column is changed from 10 to 16. It's better to ensure that this change does not affect other parts of the application.

2. It's important to make sure that the dataKey of the column matches the actual data in the table. The dataKey should be accurate and consistent.

3. The customCell should be specified correctly and should match the actual cell type. If the wrong cell type is used, it may cause problems in the application.

4. It's good practice to add comments to explain the purpose of the changes so that future developers can easily understand the code.

[cr-gpt]

the code review

The code looks good. We can see that the 'indent' property of the TableColumn type has been changed from the default '12' to '-', which means that the indentation for the tree data will now be undefined. This could potentially lead to unexpected behavior and should be tested thoroughly before deploying.

We can also suggest that the 'disabled' property should have a default value if it is not specified by the user, as this could also lead to unexpected behavior. Additionally, the function signature for 'onChange' and 'onExpand' should be checked to make sure they are properly handling the data they receive.

[cr-gpt]

with the code review:

1. The code should be properly indented and formatted for easy readability.
2. The use of variables should be optimized.
3. The cacheSelectedMap variable should be declared outside the emitChange function.
4. The if-else statement should be used to check if the data exists in the dataMap.
5. Comments should be added to explain the logic of the code.

[cr-gpt]

code review:

1. It looks like the code is checking for disabled state before proceeding further. This is good as it provides a secure way of handling user input.
2. The code is using the slots API to get customIcon if provided and fallback to icon if not. This is also a good practice.
3. The code also checks if the iconRender is a function or a string and accordingly sets the icon node.
4. The code also adds a button with class and type attributes which is a good practice.
5. Overall, the code looks well written and secure. There are no major risks or improvements that come to mind.

[codecov]

Codecov Report

Merging #1484 (69497c6) into main (e044390) will not change coverage.
The diff coverage is n/a.

❗ Current head 69497c6 differs from pull request most recent head 1c13040. Consider uploading reports for the commit 1c13040 to get more accurate results

@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         331      331           
  Lines       30742    30742           
  Branches     3533     3533           
=======================================
  Hits        28511    28511           
  Misses       2231     2231           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.