fix(comp:textarea): measureTextarea removeChild error #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| textarea.parentNode!.removeChild(clonedTextarea) | ||
| if (clonedTextarea.parentNode) { | ||
| clonedTextarea.parentNode.removeChild(clonedTextarea) | ||
| } | ||
|
|
||
| return measureRes | ||
| } |
There was a problem hiding this comment.
with a brief review of the code patch
The patch adds an extra conditional check to ensure that the clonedTextarea element has a parent node before proceeding to delete it. This is a good practice as it ensures that any dependencies to the element are handled properly and prevents potential errors. The code also looks well structured and it is easy to read. Therefore, I suggest no changes to this code.
danranVm
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
removeChild 调用时，clonedTextarea 并不是其子元素
What is the new behavior?
增加判断，解决以上问题
Other information